bugfix: incorporate type filtering in commands and expand targetFilters#57
Open
brycentrivir wants to merge 1 commit into
Open
bugfix: incorporate type filtering in commands and expand targetFilters#57brycentrivir wants to merge 1 commit into
brycentrivir wants to merge 1 commit into
Conversation
…ilters, etc. Updated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biggest change is in any GlossarySchemaByNameAndObjectType functions. Took away combination with ObjectType to match process like secretstores for example. Searches by name alone if no objectType provided and if duplicates are found (unique if by type) then throw error to require type, otherwise name alone works.
ObjectType can be used as a mass filter in most commands and the lib ops for glossaries needed that update. All these updates called for test updates so those are here as well. ApplicationOps has a change because of previously mentioned function changes.
Updates to targetFilters to incorporate previously mentioned changes as well.