feat: Including creation timestamp variables to excluded list by default#48
Closed
brycentrivir wants to merge 1 commit into
Closed
feat: Including creation timestamp variables to excluded list by default#48brycentrivir wants to merge 1 commit into
brycentrivir wants to merge 1 commit into
Conversation
phalestrivir
approved these changes
Apr 9, 2026
There was a problem hiding this comment.
Only thing I noticed was that we need to run npm run lint:fix, but that's it so I'm going to approve this, and before you create the PR against Rockcarver just make sure to run lint and also rebase.
Just so you are aware, if lint finds anything that needs to be fixed, it could throw an error when you try to create the PR against Rockcarver since they run lint as part of the tests they run to verify the PR can be merged in, so we always want to run it before we create a PR.
brycentrivir
force-pushed
the
feature/remove-creation-timestamps
branch
from
ade846d to
c0f78fa
Compare
… include by default unless -M flag is used
brycentrivir
force-pushed
the
feature/remove-creation-timestamps
branch
from
c0f78fa to
158b716
Compare
Author
|
Starting a PR with rockcarver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to default exclusion list 'createdBy, creationDate, createdDate'. In conjuction with a CLI PR which changes -M flag instructions to include same variables as examples as well.