Skip to content

fix: Remove pip3 install tritonclient[all]#8818

Open
yinggeh wants to merge 1 commit into
mainfrom
yinggeh/tri-1179-remove-pip3-install-tritonclientall
Open

fix: Remove pip3 install tritonclient[all]#8818
yinggeh wants to merge 1 commit into
mainfrom
yinggeh/tri-1179-remove-pip3-install-tritonclientall

Conversation

@yinggeh

@yinggeh yinggeh commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

L0_infer compose/cpu-only jobs run qa/L0_infer/install_and_test.sh, which did pip3 install tritonclient[all] from public PyPI. That public wheel lacks ml_dtypes support and overwrites the in-container client, breaking the tests until the next public client release. This PR removes that pip3 install so the in-container tritonclient (built with ml_dtypes, supplied via the SDK image) is used instead.

Commit Type:

  • test

Related PRs:

  • tritonserver MR: wires py3-sdk-manifest into the seven L0_infer jobs so the SDK client is available (dl/dgx/tritonserver yinggeh/tri-1180-add-py3-sdk-manifest-as-dependency).

Where should the reviewer start?

  • qa/L0_infer/install_and_test.sh

Test plan:

  • Run the L0_infer compose/cpu-only jobs with the matching tritonserver branch and confirm they pass (no ml_dtypes import error).
  • CI Pipeline ID:

Caveats:

  • Requires the tritonserver side (py3-sdk-manifest dependency) so the SDK client image is present.

Background

The public tritonclient[all] wheel trails main and omits ml_dtypes, so installing it inside the test container regressed L0_infer.

Related Issues:

  • Resolves TRI-1179

@yinggeh yinggeh force-pushed the yinggeh/tri-1179-remove-pip3-install-tritonclientall branch from 270e9f8 to 3e6c394 Compare June 10, 2026 04:17
@yinggeh yinggeh force-pushed the yinggeh/tri-1179-remove-pip3-install-tritonclientall branch from 3e6c394 to e4d1fb0 Compare June 10, 2026 04:47
@yinggeh yinggeh changed the title fix: Remove pip3 install tritonclient[all] from L0_infer install_and_test.sh fix: Remove pip3 install tritonclient[all] Jun 10, 2026
@yinggeh yinggeh self-assigned this Jun 10, 2026
@yinggeh yinggeh requested review from mc-nv and whoisj June 10, 2026 04:49
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

1 participant