build: Remove Windows from core build (TRI-725)#501
Merged
Conversation
Strips Windows-specific branches from the core build system, mirroring
TRI-723 (#8812) which removed Windows from the server build.
Removed:
- core/CMakeLists.txt: MSVC compile-options block for the
triton-core-serverstub stub library, and the platform-varying
`if (WIN32)` block setting `_FINDPACKAGE_PROTOBUF_CONFIG_DIR`.
- core/src/CMakeLists.txt: MSVC compile-options block for
triton-core, and three `if (NOT WIN32)` wrappers around
`-Wno-missing-field-initializers` on filesystem/api.cc, the
`dl`/`numa` link, and the unit-test subdirectory.
- core/src/test/CMakeLists.txt: four `if (NOT WIN32)` wrappers
around `dl`/`numa` linkage for response_cache_test, memory_test,
pinned_memory_manager_test, and metrics_api_test.
Linux behavior is unchanged. Every removed branch was either a
never-fired Windows path (MSVC compile flags, `if (WIN32)`) or an
`if (NOT WIN32)` wrapper whose contents already executed on Linux.
Source-level Windows code in core (`#ifdef _WIN32` blocks in
implementation files, `__declspec(dllexport)` macros in public
headers, etc.) is out of scope for this ticket and remains in place.
Contributor
|
Remove linear details (internal use only). And use template for description here https://github.com/triton-inference-server/server/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes Windows-specific logic from Triton Core's build system as part of TRI-725, following the Windows build removal in
server(TRI-723).This change is limited to CMake/build files and removes obsolete Windows-only build paths (
WIN32,NOT WIN32, andMSVCconditionals) while preserving existing Linux build behavior.Changes
Removed MSVC-specific compile option blocks from:
core/CMakeLists.txtcore/src/CMakeLists.txtRemoved Windows-specific protobuf config selection and kept the Linux protobuf path.
Removed
NOT WIN32wrappers around:filesystem/api.ccdlandnumalinkingcore/src/testsubdirectory inclusionresponse_cache_test,memory_test,pinned_memory_manager_test, andmetrics_api_testVerification
No Windows-specific build references remain under
core/build files.Changes are contained to:
core/CMakeLists.txtcore/src/CMakeLists.txtcore/src/test/CMakeLists.txtNotes
This PR only removes Windows support from the build system. Source-level Windows code remains unchanged and will be handled separately if needed.