fix: Modernize Child Path Detection#497
Merged
Merged
Conversation
mudit-eng
reviewed
May 12, 2026
Contributor
|
How do we validate this code works? |
This change updates the alogrithm used to detect if a 'child path' escapes its parent.
yinggeh
reviewed
May 13, 2026
Contributor
Author
One would assume our CI tests cover most if not all cases. I'll see to it that a new one with the case that this PR fixes is added. |
yinggeh
reviewed
May 13, 2026
yinggeh
reviewed
May 13, 2026
yinggeh
reviewed
May 14, 2026
yinggeh
reviewed
May 15, 2026
| /// \param c The character to check. | ||
| /// \return `true` when the character is a path separator, otherwise `false`. | ||
| bool IsPathSeparator(char c); | ||
| inline bool |
Contributor
There was a problem hiding this comment.
I believe the function should be in anonymous namespace in api.cc instead of making a public interface of class LocalizedPath.
Contributor
There was a problem hiding this comment.
I wonder if there is a need of this function given that Triton does not have Windows support.
yinggeh
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the algorithm used to detect if a 'child path' escapes its parent.