Show Edit button for gitlab connections#29
Merged
Conversation
GitLab uses a personal access token (no OAuth refresh / no
Re-authenticate flow), so when a gitlab connection lands in
status=reauth_required (e.g. token revoked or expired and Validate
returned ErrNeedsReauth) the operator had no remedy: the
Re-authenticate button is google-only and the Edit button was
gated on http_proxy / mcp_proxy / github.
Add gitlab to the Edit-button condition. GitLab's connector Meta()
already declares both fields (token + base_url) as Editable=true, so
the generic data-driven /connections/{id}/edit page is the right
landing place — the operator pastes a fresh PAT, saves, and the
update flows through the existing UpdateConfig path which clears
reauth_required on success.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI dead-end for GitLab connections that enter status=reauth_required by ensuring the Connections list displays an Edit link for gitlab connector rows. This aligns the list UI with the existing generic, data-driven edit page backed by connector Meta().SetupFields.
Changes:
- Allow the Edit action link to appear for
gitlabconnector types in the connections table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitLab connections in
status=reauth_required(e.g. PAT revoked / expired) had no remedy UI: the Re-authenticate button is google-only, and the Edit button was gated onhttp_proxy/mcp_proxy/github. The operator was stuck — no clickable way to update the token.Add
gitlabto the Edit-button condition. The GitLab connector'sMeta().SetupFieldsalready declare bothtokenandbase_urlasEditable=true, so the generic data-driven edit page is the right landing place. Operator pastes a fresh PAT, hits Save, and the existingUpdateConfigpath clearsreauth_requiredon success.Test plan
reauth_required(e.g. via a sqlUPDATE connections SET status='reauth_required' WHERE id='...')./connections/{id}/editwith the token field empty (Secret) and base_url pre-filled./connectionswith the row back toactive.🤖 Generated with Claude Code