refactor: remove unused tsm rr fallback#1054
Merged
jranson merged 2 commits intoJul 8, 2026
Merged
Conversation
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
Member
|
@houyuwushang in this change it would be good to describe the non-merge fallback behavior (dispatching to the first live pool target) in the ALB TSM Documentation. Otherwise, looks good. |
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
Contributor
Author
|
Thanks, added that note to the TSM docs. The local TSM/ALB package tests still pass, and CI is green. |
jranson
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1009.
TSM was still constructing a round-robin fallback handler, but
ServeHTTPno longer uses it. Non-merge paths, missing request resources, and the single-member fast path already dispatch directly to the first live pool target.This removes the unused
rrdependency, adds a test that pins the current non-merge fallback behavior, and documents that fallback in the ALB TSM docs.Type of Change
AI Disclosure
Tests
go test ./pkg/backends/alb/mech/tsm -run 'Test(New|HandlerStopPool|TSMNonMergePathUsesFirstLiveMember|HandleResponseMerge)$' -count=1go test ./pkg/backends/alb/mech/tsm -count=1go test ./pkg/backends/alb/... -count=1go tool golangci-lint run --timeout 5m ./pkg/backends/alb/mech/tsmgit diff --check(only local Windows autocrlf warnings)