refactor(alb): avoid options in ALB constructors#1051
Conversation
|
I'm not sure if this is the best approach to solve the issue, so let me know what you think about it. An alternative approach could be to create a custom |
|
I took a pass over this from the #1011 angle. The CI is green, and I also checked the related packages locally:
Two things I think are worth considering before this lands:
Not blocking from my side, but I think those two points would make the intended API boundary clearer. |
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
e7298f7 to
d682ea8
Compare
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
Description
This PR resolves a design issue in the Application Load Balancer (ALB) constructor, previously the time_series_merge constructor was relying on fields from the general
Optionsstruct that were not actually related to the ALB itself, but rather belonged to a more Backend-style configuration.To address this and improve separation of concerns, I introduced a new
ALBConfigsstruct to replaceOptionsin the constructor. This is because, in practice, load balancing algorithm constructors rarely need the entireOptionsstruct, but rather just a few specific fields.Changes
ALBConfigs: Created a new struct tailored specifically for ALB requirements, decoupling it from the broaderOptions.Newfactory functions to acceptALBConfigsinstead ofOptions.Related Issue: #1011
Type of Change
AI Disclosure