docs: update OTLP tracing examples#1049
Merged
jranson merged 1 commit intoJul 3, 2026
Merged
Conversation
jranson
requested changes
Jul 3, 2026
| - 5778:5778 | ||
| - 16686:16686 | ||
| - 4318:4318 | ||
| - 14268:14268 |
Member
There was a problem hiding this comment.
is 14268 port mapping still needed? would be a good idea to git grep 14268 from the project root to identify all remaining usage and address any other holdovers.
Contributor
Author
There was a problem hiding this comment.
Done. I removed the remaining 14268:14268 mappings from both compose files because Trickster no longer references that endpoint in these examples.
I also reran git grep 14268 from the project root and it now returns no matches.
Validation after the update:
git grep -n 14268returns no matchesgo run ./cmd/trickster -validate-config -config examples\docker-compose\docker-compose-data\trickster-config\trickster.yamlgo run ./cmd/trickster -validate-config -config docs\developer\environment\trickster-config\trickster.yamlgo test ./pkg/observability/tracing/... -count=1git diff --check
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
172436a to
7ecc98f
Compare
jranson
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #381.
This updates the tracing docs and examples to match the current OTLP exporter behavior. Trickster currently uses OTLP over HTTP (
otlptracehttp), but several examples still pointed at Jaeger's legacy collector/agent endpoints (14268/api/traces,6831) or oldprovider: jaegeroptions.This PR:
http://...:4318/v1/traces4318) in the docker-compose demo/dev servicesdocs/tracing.mdto link to the current example config instead of the oldv1.1.2exampleNo runtime behavior changes are intended.
Validation:
rg -n "provider:\s*jaeger|jaeger\.endpoint_type|jaeger:6831|127\.0\.0\.1:6831|14268/api/traces|jaeger agent|jager agent|otlp agent backend|endpoint_type|jc1|ja1|blob/v1\.1\.2/examples/conf/example\.full\.yaml" docs examples deploy README.md pkg -g "*.md" -g "*.yaml" -g "*.yml" -g "*.go"returns no stale Trickster tracing examplesgo run ./cmd/trickster -validate-config -config examples\docker-compose\docker-compose-data\trickster-config\trickster.yamlgo run ./cmd/trickster -validate-config -config docs\developer\environment\trickster-config\trickster.yamlgo test ./pkg/observability/tracing/... -count=1git diff --checkNot run locally:
docker compose config, because Docker CLI is not installed in my local environment.Type of Change
AI Disclosure