Offload tool call persistence to executor for faster SSE#64
Merged
Conversation
SSE event was blocked on disk I/O before reaching the client. Submitting the INSERT to the existing virtual-thread executor lets events.publish() run immediately after the tool finishes, while the write happens concurrently. The batch save in onComplete writes to a separate table (chat_message), so there is no ordering dependency. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0185eo9C1XmDGioNAvUPweNv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defer database persistence of tool call state to a background executor to prevent blocking Server-Sent Events (SSE) on disk I/O.
Changes
chatMemoryService.saveToolCallIncremental()call inexecutor.execute()to run asynchronouslytcm.toolCall()to a local variable to ensure consistent reference in the async closureImplementation Details
The tool call persistence is now treated as non-blocking bookkeeping. When a tool invocation completes (status != STARTED), the state is saved to the database in the background while the SSE event is published immediately. This improves perceived responsiveness of the chat interface without sacrificing durability, since the tool call data is still persisted—just not synchronously.