Update Prometheus installation instructions on SLES for SAP 16.0#209
Conversation
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
question: why the changes in the images? It seems they are the same, no? Or is there any real change? If not, please discard the changes.
Otherwise, LGTM!
| ---- | ||
| + | ||
| Note: the value of the `url` parameter above assumes that the {tr_web} service is running in the same host as {prometheus} Server. | ||
| NOTE: the value of the `url` parameter above assumes that the {tr_web} service is running in the same host as {prometheus} Server. |
There was a problem hiding this comment.
comment: I like change, but, I'd try to make it consistent across the whole documentation base. I mean, not now or in this PR, but rather something for the future.
|
Thank you @antgamdia for the review! Just to clarify the images: I have just optimized their sizing with our documentation tool 👍 If everything looks good now, could you approve? Thank you! 🙏 |
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Sure! Thanks!
Since I saw the same dimensions in the diff, I assumed there were no changes. But if they are optimized, that's ok! +1ing
abravosuse
left a comment
abravosuse
left a comment
There was a problem hiding this comment.
I have built the document with the changes locally and it looks great. Thank you!
… (#210) Update Prometheus installation instructions on SLES for SAP 16.0
3 participants
Description:
Correct the 16.0 procedure -> because the 16.0 now mirrors the 15.x, I combined them into one:
Old:
New:
Jira:
https://jira.suse.com/browse/TRNT-4461
Branches:
main,latestAdditional information: