Improve the sumdbverify client tool - #51
Merged
Merged
Conversation
Now compares the go.mod file contents match between the git repository for each version, and that served in SumDB. Note that this still doesn't calculate and compare the zip file hash. Misc smaller changes: - Much better output: proper tabular output and granular info - Pre-refactoring ready to accept non-VIndex SumDB info - Switch away from os.Exec to use proper git implementation - README for the sumdbverify command directly
mhutchinson
force-pushed
the
sumdb-full-verify
branch
from
October 1, 2025 12:15
3557c2c to
4f28d4a
Compare
AlCutter
approved these changes
Oct 1, 2025
mhutchinson
commented
Oct 1, 2025
mhutchinson
left a comment
mhutchinson
left a comment
Contributor
Author
There was a problem hiding this comment.
Cheers, took some doing but done. Using Hash1 was a good idea in the end. I resisted it because I'd already committed to unpacking that format when I parsed sumdb. I've changed it so that we don't do that, and instead the comparison is done using the raw strings with the h1 prefix.
mhutchinson
force-pushed
the
sumdb-full-verify
branch
from
October 1, 2025 14:54
60ac6b3 to
365f97a
Compare
AlCutter
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now compares the go.mod file contents match between the git repository
for each version, and that served in SumDB. Note that this still doesn't
calculate and compare the zip file hash.
Misc smaller changes: