feat(drawer): grouped-card reskin for drawers and popup menus - #2992
Open
ElMagnea wants to merge 5 commits into
Open
feat(drawer): grouped-card reskin for drawers and popup menus#2992ElMagnea wants to merge 5 commits into
ElMagnea wants to merge 5 commits into
Conversation
ElMagnea
force-pushed
the
feat/drawer-revamp
branch
from
July 23, 2026 10:32
2076b04 to
328f172
Compare
Contributor
|
@ElMagnea can we also reorder actions on recommendations for example? Not have to "why this?" Next to "ignore" Please do this on a separate PR 🙏 |
Marius-TV
force-pushed
the
main
branch
3 times, most recently
from
August 2, 2026 05:08
d6ed106 to
637bdc2
Compare
5 tasks
seferturan
pushed a commit
that referenced
this pull request
Aug 5, 2026
Move "View recommendation sources" to the start of the action menu so users can first understand why a recommendation appears, followed by the main actions (watchlist, watched, list), and the destructive "Hide recommendation" action at the end. Addresses feedback from PR #2992 about action ordering clarity. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
trakt-bot Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
Move "View recommendation sources" to the start of the action menu so users can first understand why a recommendation appears, followed by the main actions (watchlist, watched, list), and the destructive "Hide recommendation" action at the end. Addresses feedback from PR #2992 about action ordering clarity. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ElMagnea
force-pushed
the
feat/drawer-revamp
branch
from
August 5, 2026 16:04
328f172 to
c76c259
Compare
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage  |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Aug 18, 2026 5:52p.m. | Review ↗ |
| Code coverage | |
Aug 18, 2026 5:52p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 69.2% |
| Javascript | 69.2% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
seferturan
force-pushed
the
feat/drawer-revamp
branch
2 times, most recently
from
August 18, 2026 17:50
30e8fa7 to
3202a3c
Compare
Wider bar is easier to grab. Colour and hit area stay as they were.
Adds DropdownGroup, which flattens the DropdownItems inside it into one elevated card with hairline-divided rows. Items resolve their layout and surface through configuration tokens, so the group sets those on the list instead of overriding items from the outside. Adopts it in the action menus: popup menus on mobile, manage lists, track, watch until here, and the summary actions.
Each sort option carries an optional description, rendered as a subtitle in the sort drawer, so the difference between smart, release date and remaining is readable without guessing.
The restyling rule assumes reachable props; Snippet children have none. Points at the fallback-carrying custom property instead of a :global() override.
seferturan
force-pushed
the
feat/drawer-revamp
branch
from
August 18, 2026 17:52
3202a3c to
c557d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visuals
What & why
The drawers and popup menus were visually dated — filled "pill" rows with gaps, no shared surface, inconsistent chrome. This reskins them into a single grouped card language (elevated surface, flush hairline-divided rows, subtle hover/press, eyebrow titles) applied consistently across the app.
The reusable primitive
Every menu now routes through one of two components instead of hand-rolling its own list:
DropdownGroup— grouped card that flattens childDropdownItems (filled pills → flush divided rows). Containers pass items as opaque snippets, so the flatten is done via scoped overrides in one place.OptionList/OptionListItem— the same card as first-class components (icon · title · optional subtitle · trailing slot), used where items aren'tDropdownItems.Coverage
PopupMenuOptionList+ two-line subtitlesAudited every component with 2+
DropdownItems — no ungrouped menu containers remain.Also in here
Drawer: eyebrow title as the default (titleStyle="prominent"opt-out for content-name titles like show/episode names, auto-forced when a drilldown title is set); refined drag handle; more handle-to-title spacing.--color-option-list-border) so cards don't read as white/transparent.--color-drawer-drag-handle,--color-option-list-background/-border/-separator/-highlight.Verification
deno fmtclean ·svelte-check0 errors / 0 warnings ·vitest2414 passed / 7 skipped.Screenshots
To be added.
🤖 Generated with Claude Code