Skip to content

fix: specify smart list filter ranges types for proper Kotlin gen. #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaldrabik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: specify smart list filter ranges types for proper Kotlin gen. #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions projects/api/src/contracts/_internal/request/smartListFiltersSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { z } from '../z.ts';
import { float, z } from '../z.ts';

const list = z.array(z.string());
const range = z.array(z.number()).max(2);
const intRange = z.array(z.number().int()).max(2);
const floatRange = z.array(float(z.number())).min(2);

// Applies to the include arm only: 'and' requires every value, 'or' (default)
// any of them. Exclusion is always "carries none of".
Expand All @@ -20,14 +21,14 @@ export const smartListFiltersSchema = z.object({
keywords: list.optional(),
keywords_operator: operator.optional(),
watchnow: list.optional(),
years: range.optional(),
ratings: range.optional(),
runtimes: range.optional(),
imdb_ratings: range.optional(),
rt_meters: range.optional(),
rt_user_meters: range.optional(),
letterboxd_ratings: range.optional(),
mal_ratings: range.optional(),
years: intRange.optional(),
ratings: intRange.optional(),
runtimes: intRange.optional(),
imdb_ratings: floatRange.optional(),
rt_meters: intRange.optional(),
rt_user_meters: intRange.optional(),
letterboxd_ratings: floatRange.optional(),
mal_ratings: floatRange.optional(),
ignore_watched: z.boolean().optional(),
ignore_watchlisted: z.boolean().optional(),
ignore_watching: z.boolean().optional(),
Expand Down
2 changes: 1 addition & 1 deletion projects/api/src/contracts/_internal/response/listMetadataResponseSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ export const listMetadataResponseSchema = z.object({
rank: z.number().int(),
id: z.number().int(),
listed_at: z.string().datetime(),
notes: z.string().nullish(),
notes: z.string().nullish()
});
2 changes: 1 addition & 1 deletion projects/api/src/contracts/users/schema/response/favoritedMoviesResponseSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ export const favoritedMoviesResponseSchema = z.object({
id: z.number().int(),
listed_at: z.string().datetime(),
notes: z.string().nullish(),
rank: z.number().int(),
rank: z.number().int()
}).merge(typedMovieResponseSchema);
2 changes: 1 addition & 1 deletion projects/api/src/contracts/users/schema/response/favoritedShowsResponseSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ export const favoritedShowsResponseSchema = z.object({
id: z.number().int(),
listed_at: z.string().datetime(),
notes: z.string().nullish(),
rank: z.number().int(),
rank: z.number().int()
}).merge(typedShowResponseSchema);
Loading