Skip to content

ci(commitlint): Run commit message check on dev as well#82

Merged
nfebe merged 1 commit intodevfrom
chore/extend-commitlint-coverage
May 3, 2026
Merged

ci(commitlint): Run commit message check on dev as well#82
nfebe merged 1 commit intodevfrom
chore/extend-commitlint-coverage

Conversation

@nfebe
Copy link
Copy Markdown
Contributor

@nfebe nfebe commented May 3, 2026

Commit message validation only ran on pull requests targeting main, so non-conforming subjects could land on dev unnoticed and only surface when the dev to main release PR was opened.

The check now also runs on pushes and pull requests against dev so violations are caught at the original review.

Commit message validation only ran on pull requests targeting main, so
non-conforming subjects could land on dev unnoticed and only surface
when the dev to main release PR was opened.

The check now also runs on pushes and pull requests against dev so
violations are caught at the original review.
@sourceant
Copy link
Copy Markdown

sourceant Bot commented May 3, 2026

Code Review Summary

This PR updates the GitHub Actions workflow for commit message validation to run on both main and dev branches. Previously, it only targeted main, which allowed non-compliant commits to accumulate on dev before being discovered during a release cycle.

🚀 Key Improvements

  • Extends .github/workflows/commits.yml to trigger on dev for both push and pull_request events.

Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying webui with  Cloudflare Pages  Cloudflare Pages

Latest commit: a96963b
Status: ✅  Deploy successful!
Preview URL: https://1a781d37.webui-9fh.pages.dev
Branch Preview URL: https://chore-extend-commitlint-cove.webui-9fh.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying trakli-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: a96963b
Status: ✅  Deploy successful!
Preview URL: https://d2359ee0.trakli-dev.pages.dev
Branch Preview URL: https://chore-extend-commitlint-cove.trakli-dev.pages.dev

View logs

@nfebe nfebe merged commit 7f5c0ea into dev May 3, 2026
6 checks passed
@nfebe nfebe deleted the chore/extend-commitlint-coverage branch May 3, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant