Skip to content

added error for non-array policy declaration #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weyj4 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added error for non-array policy declaration #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef8c11
added error for non-array policy declaration
weyj4 Apr 6, 2016
598ae45
throwing an error here
weyj4 Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ module.exports = {
decorateRouteWithPrerequisites (app, route) {
const policies = app.config.policies
const prerequisites = lib.Util.getRoutePrerequisites(policies, route)
if (!_.isArray(prerequisites)) {
throw new TypeError(['trailpack-router: policy', prerequisites, 'must be an array.'].join(' '))
}

@tjwebb tjwebb Apr 15, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should return here, right? Otherwise, the app will still try to use the wrong value. I think we want to ignore this policy config, and throw the error

@tjwebb tjwebb Apr 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weyj4 if you can add in this fix, I can merge. Looks good otherwise.


return _.defaultsDeep({ }, route, {
config: {
Expand Down