Fix spurious scrollbar on accounts page#254
Closed
zyrakq wants to merge 1 commit into
Closed
Conversation
Removed h-full from the AccountsPage root div to prevent sub-pixel height overflow from producing a spurious scrollbar Added overflow-y-auto to the TopNav main element so tall content scrolls inside the panel instead of the document body AccountsPage produced a scrollbar even when content was shorter than the viewport due to h-dvh vs 100% sub-pixel rounding in the browser
Contributor
|
Much appreciated 🙏 . Cherry-picked this change verbatim into the dev branch: 7b26aaf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed h-full from the AccountsPage root div to prevent sub-pixel height overflow from producing a spurious scrollbar Added overflow-y-auto to the TopNav main element so tall content scrolls inside the panel instead of the document body
AccountsPage produced a scrollbar even when content was shorter than the viewport due to h-dvh vs 100% sub-pixel rounding in the browser