Update pl_pl.json#297
Merged
Merged
Conversation
WalkthroughPolish localization file for EntityCulling is expanded from minimal strings to a comprehensive set, updating existing translations and adding new keys for UI elements, tabs, toggles, and tooltips related to entity and block-entity culling features. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/resources/assets/entityculling/lang/pl_pl.json`:
- Around line 23-24: Update the value for
"text.entityculling.blockEntityFrustumCulling.tooltip" to a clearer Polish
phrasing stating that block entities are culled against the camera frustum; for
example: "Po włączeniu, byty blokowe poza ostrosłupem widzenia kamery (frustum)
będą odrzucane, co może poprawić wydajność, jeśli inny mod tego nie robi."
Ensure you edit only the tooltip string for the key
"text.entityculling.blockEntityFrustumCulling.tooltip".
- Around line 2-3: The JSON language files include an unused keybinding category
key "key.category.minecraft.text.entityculling.title" that isn't referenced
anywhere (the code uses "text.entityculling.title"); remove every occurrence of
"key.category.minecraft.text.entityculling.title" from all locale JSON files
(including en_us, de_de, zh_cn, zh_tw, uk_ua, pt_br, es_ar, pl_pl, etc.) so only
"text.entityculling.title" remains; ensure you don't alter or remove the used
key "text.entityculling.title" and run a quick JSON lint to verify no trailing
commas or syntax issues after deletion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 997f942b-7a67-4388-87cb-8c34ac4f538f
📒 Files selected for processing (1)
src/main/resources/assets/entityculling/lang/pl_pl.json
Comment on lines
+2
to
+3
| "text.entityculling.title": "EntityCulling", | ||
| "key.category.minecraft.text.entityculling.title": "EntityCulling", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -n 'key\.category\.minecraft\.text\.entityculling\.title|text\.entityculling\.title' src/main/java src/main/resourcesRepository: tr7zw/EntityCulling
Length of output: 3670
Remove the unused keybinding category key from all language files.
The key key.category.minecraft.text.entityculling.title is not referenced anywhere in the codebase. Java code uses only text.entityculling.title for the screen title. This extra key is also inconsistently present—it appears in en_us, de_de, zh_cn, zh_tw, uk_ua, pt_br, es_ar, and pl_pl but is absent from hu_hu, id_id, vi_vn, fr_fr, it_it, ms_my, fa_ir, and others. Remove it from all language files for consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/main/resources/assets/entityculling/lang/pl_pl.json` around lines 2 - 3,
The JSON language files include an unused keybinding category key
"key.category.minecraft.text.entityculling.title" that isn't referenced anywhere
(the code uses "text.entityculling.title"); remove every occurrence of
"key.category.minecraft.text.entityculling.title" from all locale JSON files
(including en_us, de_de, zh_cn, zh_tw, uk_ua, pt_br, es_ar, pl_pl, etc.) so only
"text.entityculling.title" remains; ensure you don't alter or remove the used
key "text.entityculling.title" and run a quick JSON lint to verify no trailing
commas or syntax issues after deletion.
Comment on lines
+23
to
+24
| "text.entityculling.blockEntityFrustumCulling": "Frustum culling bytów blokowych", | ||
| "text.entityculling.blockEntityFrustumCulling.tooltip": "Gdy jest włączone, ekstrakcja stanu bytów blokowych będzie odrzucana na podstawie frustum kamery. Może to poprawić wydajność, jeśli Twój modloader lub inny mod nie robi tego już wcześniej.", |
There was a problem hiding this comment.
Reword the block-entity frustum tooltip.
"ekstrakcja stanu bytów blokowych" does not match the setting and reads awkwardly in Polish. Please rephrase it so it clearly says block entities are culled against the camera frustum.
💡 Suggested wording
- "text.entityculling.blockEntityFrustumCulling.tooltip": "Gdy jest włączone, ekstrakcja stanu bytów blokowych będzie odrzucana na podstawie frustum kamery. Może to poprawić wydajność, jeśli Twój modloader lub inny mod nie robi tego już wcześniej."
+ "text.entityculling.blockEntityFrustumCulling.tooltip": "Gdy jest włączone, byty blokowe będą odrzucane na podstawie frustum kamery. Może to poprawić wydajność, jeśli Twój modloader lub inny mod nie robi tego już wcześniej."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "text.entityculling.blockEntityFrustumCulling": "Frustum culling bytów blokowych", | |
| "text.entityculling.blockEntityFrustumCulling.tooltip": "Gdy jest włączone, ekstrakcja stanu bytów blokowych będzie odrzucana na podstawie frustum kamery. Może to poprawić wydajność, jeśli Twój modloader lub inny mod nie robi tego już wcześniej.", | |
| "text.entityculling.blockEntityFrustumCulling": "Frustum culling bytów blokowych", | |
| "text.entityculling.blockEntityFrustumCulling.tooltip": "Gdy jest włączone, byty blokowe będą odrzucane na podstawie frustum kamery. Może to poprawić wydajność, jeśli Twój modloader lub inny mod nie robi tego już wcześniej.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/main/resources/assets/entityculling/lang/pl_pl.json` around lines 23 -
24, Update the value for "text.entityculling.blockEntityFrustumCulling.tooltip"
to a clearer Polish phrasing stating that block entities are culled against the
camera frustum; for example: "Po włączeniu, byty blokowe poza ostrosłupem
widzenia kamery (frustum) będą odrzucane, co może poprawić wydajność, jeśli inny
mod tego nie robi." Ensure you edit only the tooltip string for the key
"text.entityculling.blockEntityFrustumCulling.tooltip".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.