feat(audio): ES7210 Linux analog register config (REG20-23/47-4C) — A/B candidate#42
Draft
torlando-tech wants to merge 1 commit into
Draft
feat(audio): ES7210 Linux analog register config (REG20-23/47-4C) — A/B candidate#42torlando-tech wants to merge 1 commit into
torlando-tech wants to merge 1 commit into
Conversation
…/B candidate Applies the explicit ADC-dynamics/HPF (REG20-23) + mic-ALC/power (REG47-4C) writes the Linux es7210 driver makes, which the LilyGO/ESP-ADF init leaves at reset defaults. Added while chasing an asymmetric-THD theory; the dominant garble was later proven to be acoustic feedback, so the benefit of these writes is UNVERIFIED. DO NOT MERGE until A/B-tested against a clean acoustic source — origin/main is the 'without' baseline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWZuYkHBRqNb6BZHV8sTG5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the explicit ADC-dynamics/HPF (REG20-23) + mic-ALC/power (REG47-4C) register writes the Linux es7210 driver (rockchip-linux/kernel) makes but the LilyGO/ESP-ADF init leaves at reset defaults.
These were added while chasing an asymmetric-THD theory during the voice investigation; the dominant "garble" was later proven to be acoustic feedback in the test rig, so the benefit of these analog writes is UNVERIFIED. They need an A/B test against a clean acoustic source (real voice, not the distorting close Mac speaker) before merging —
origin/mainis the "without" baseline.🤖 Generated with Claude Code
https://claude.ai/code/session_01UWZuYkHBRqNb6BZHV8sTG5