ci: fail-soft on Codecov upload, fix coverage path#119
Open
trishorts wants to merge 1 commit into
Open
Conversation
The Build and Test job failed on all open PRs (#116, #117, #118) because the final Codecov step errored on upload (exit 4294967295) while fail_ci_if_error was true, marking the whole job failed even though restore, build, and tests all passed (235 passed, 0 failed). - fail_ci_if_error: true -> false so a Codecov-side hiccup no longer fails the build - fix coverage file path: coverage.net6.0.xml -> coverage.xml to match the Coverlet output (/p:CoverletOutput='../../coverage.xml') - bump checkout/setup-dotnet/codecov-action v3 -> v4 to clear the Node 20 deprecation warnings Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 89.65% 89.25% -0.41%
==========================================
Files 103 103
Lines 5702 5721 +19
Branches 878 882 +4
==========================================
- Hits 5112 5106 -6
- Misses 424 429 +5
- Partials 166 186 +20 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All three open PRs (#116, #117, #118) fail the single Build and Test
check. The failure is not in any PR's code — restore, build, and tests all
pass (#116 shows 235 passed, 7 skipped, 0 failed across net472 + net6.0).
The only error is the Codecov upload step failing with exit code
4294967295.
Root cause
.github/workflows/dotnet.ymlrunscodecov/codecov-action@v3withfail_ci_if_error: true, so any Codecov upload error fails the entire jobregardless of test results. Two config issues make the upload error likely:
files:pointed atcoverage.net6.0.xml, but the test step writescoverage.xml(/p:CoverletOutput='../../coverage.xml'), so the actionhad no file to upload.
Fix
fail_ci_if_error: true->false— a Codecov hiccup no longer fails CI../coverage.xml.checkout,setup-dotnet, andcodecov-actionto v4 (clears theNode 20 deprecation warnings).
Note for maintainers
The underlying Codecov upload error is most likely a missing or expired
CODECOVrepo secret (public-repo tokenless uploads get rate-limited).With
fail_ci_if_error: falsethe build is green either way, but refreshingthat secret would restore actual coverage reporting.
🤖 Generated with Claude Code