Align pnpm patch version to 8.15.9 across ci.yml and package.json#34
Open
toon-backlog-bot[bot] wants to merge 1 commit into
Open
Align pnpm patch version to 8.15.9 across ci.yml and package.json#34toon-backlog-bot[bot] wants to merge 1 commit into
toon-backlog-bot[bot] wants to merge 1 commit into
Conversation
CI's build job and package.json's packageManager field still pinned pnpm@8.15.0, while devbox.json (fixed in #25) resolves to pnpm_8@8.15.9. Aligns both to the devbox-resolved version so every contributor and CI job build with the same pnpm patch version. Closes #31 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ALLiDoizCode
approved these changes
Jul 1, 2026
ALLiDoizCode
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: diff exactly matches issue #31's stated scope (ci.yml build job + package.json packageManager, both 8.15.0 → 8.15.9), plus a correctly-formatted empty changeset for this tooling-only change. Verified devbox-validate's version assertion uses a loose ^8\.15\. regex so it doesn't need touching, and confirmed release.yml's separate 8.15.0 pin (correctly left out per PR body — sensitive publish pipeline, out of scope for #31) is the only other drift. Title/body accurately describe the diff. No code, security, or standards issues found. Approving.
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Summary
.github/workflows/ci.yml: bump thebuildjob'spnpm/action-setup@v4versionfrom8.15.0to8.15.9.package.json: bump rootpackageManagerfrompnpm@8.15.0topnpm@8.15.9..changeset/issue-31-align-pnpm-version.md) since this is CI/tooling metadata, not a code change to a published package.This aligns both with
devbox.json'spnpm_8pin at8.15.9(fixed for the devbox shell in #25), so the non-devbox CIbuildjob now resolves the same pnpm patch version asdevbox shelland every contributor's pinned toolchain.Deviation from Agent Assessment
The issue's evidence/scope only lists
ci.ymlandpackage.json. While implementing, I noticed.github/workflows/release.yml:26has the identicalpnpm/action-setup@v4version: 8.15.0drift. I deliberately did not touchrelease.ymlhere — it's part of the npm-publish pipeline, which is called out as sensitive in this repo'sCLAUDE.md, and it wasn't in the issue's stated scope/acceptance criteria. Flagging it here as a candidate for a follow-up issue rather than expanding this PR's scope unilaterally.Verification
devboxwas not available in this execution environment, so verification ran directly viacorepack prepare pnpm@8.15.9 --activate(matching the new pin) instead ofdevbox run:grep -n "version: 8.15.9" .github/workflows/ci.yml✅grep -n '"packageManager": "pnpm@8.15.9"' package.json✅pnpm install --no-frozen-lockfile(pre-existing, unrelated lockfile/specifier drift inpackages/swap/package.jsonvspnpm-lock.yamlrequired--no-frozen-lockfile; confirmed this drift pre-exists onmainand is out of scope for this issue — leftpnpm-lock.yamluntouched in the final diff)pnpm -r build✅pnpm -r test✅ (130 passed, 2 skipped)pnpm lint✅ (0 errors, pre-existing warnings only)buildanddevbox-validatejobs will run on this PR.🤖 Generated with Claude Code