docs(swap): remove stale TODO(12.7) comment in claim-issuer.ts#33
Open
toon-backlog-bot[bot] wants to merge 1 commit into
Open
docs(swap): remove stale TODO(12.7) comment in claim-issuer.ts#33toon-backlog-bot[bot] wants to merge 1 commit into
toon-backlog-bot[bot] wants to merge 1 commit into
Conversation
startMill() already populates signerAddresses via buildSignerAddresses() (see mill.ts), so the "callers must supply the map explicitly" note was misleading. Comment-only change, no behavioral difference. Closes #32 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ALLiDoizCode
approved these changes
Jul 1, 2026
ALLiDoizCode
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: comment-only change, verified against issue #32 and mill.ts (buildSignerAddresses() at mill.ts:787, wired into MultiChainClaimIssuer at mill.ts:792 — claim matches code). Confirmed TODO(12.7) no longer appears in claim-issuer.ts and the new wording is accurate. Changeset uses the valid empty-frontmatter form (appropriate since this has no runtime effect). PR title/body accurately describe the diff — no changes needed. No blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO(12.7)comment block onMultiChainClaimIssuerConfig.signerAddressesinpackages/swap/src/claim-issuer.tsstartMill()inpackages/swap/src/mill.tsbuilds and passes thesignerAddressesmap viabuildSignerAddresses()(seemill.ts:786-792, and the file's own top-of-file doc comment)startMill()populates this automatically, and that the field stays optional only for callers constructingMultiChainClaimIssuerdirectly outsidestartMill()Closes #32
Verification
grep -n "TODO(12.7)" packages/swap/src/claim-issuer.ts→ no match (exit 1)pnpm -r build→ succeedspnpm -r test→ 130 passed, 2 skipped, 0 failedPlan deviation
None — followed the issue's suggested plan as written.
🤖 Generated with Claude Code