Skip to content

Support implicit TLS connections#123

Merged
tonioo merged 1 commit into
tonioo:masterfrom
kewisch:implicit-tls
Nov 21, 2025
Merged

Support implicit TLS connections#123
tonioo merged 1 commit into
tonioo:masterfrom
kewisch:implicit-tls

Conversation

@kewisch

@kewisch kewisch commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

This PR add support for implicit TLS connections which some servers (e.g. Stalwart) offer. I would normally have renamed the starttls parameter to a more general tls parameter that takes explicit/implicit/None, but this wouldn't be backwards compatible without messy migration code. If you prefer just changing the API and bumping the major version let me know.

@codecov

codecov Bot commented Nov 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.54%. Comparing base (cb690f5) to head (4339726).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sievelib/managesieve.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   87.62%   87.54%   -0.08%     
==========================================
  Files          10       10              
  Lines        2069     2072       +3     
==========================================
+ Hits         1813     1814       +1     
- Misses        256      258       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonioo

tonioo commented Nov 21, 2025

Copy link
Copy Markdown
Owner

@kewisch Thanks for this contribution

@tonioo tonioo merged commit d358d3c into tonioo:master Nov 21, 2025
7 of 9 checks passed
@tonioo

tonioo commented Nov 21, 2025

Copy link
Copy Markdown
Owner

@kewisch If you still have your dev environment running, could you please check this PR:
#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants