Extracting invites' email sending into an InviteEmail operation object - #17
Open
dcluna wants to merge 11 commits into
Open
Extracting invites' email sending into an InviteEmail operation object#17dcluna wants to merge 11 commits into
dcluna wants to merge 11 commits into
Conversation
Following the service/operation object pattern (for instance, see http://trailblazer.to/gems/operation/2.0/), we should be able to send e-mail invites decoupled from a particular controller action. This also allows one to use a different mailer class from the original. Useful when you want to configure the e-mail for a particular invitable.
[NO STORY] Update Rails version
[NO STORY] Update Rails version
Update ruby and rails
* Add circleci and remove old ruby-version file * trigger for circle * update bundler version * update circle ci config * remove junit formatter from circle ci config --------- Co-authored-by: mfitzhenry <matt@geno.me@users.noreply.github.com>
Co-authored-by: mfitzhenry <matt@geno.me@users.noreply.github.com>
* updated flaky specs and update rails version to 7.0.4.3 * update bundler version --------- Co-authored-by: mfitzhenry <matt@geno.me@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the service/operation object pattern (for instance, see http://trailblazer.to/gems/operation/2.0/), we should be able to send e-mail invites decoupled from a particular controller action.
This also allows one to use a different mailer class from the original. Useful when you want to configure the e-mail for a particular
invitable.