Promote: P2.3a handling preview - #23
Merged
Merged
Conversation
… parity (#22) * feat: P2.3a handling preview (weight/ADS composition + domains) Renderer: partHandling.ts (binary32 weight_kg/ads_time_add composition, movement/ADS preview with server-configurable policy, typed refusal codes), partOrdering.ts (canonical local part-type identity + P2.2a sort ordering, signed-int32 sort_order domain), rollCard handling section, RollPanel/Library/PartPanel/OptionalNumberField editing surfaces, libraryValidation canonical-id duplicate/slot checks + handling scalar and sortOrder domain issues. Sidecar: raw-import preflight rejecting lossy sort_order before the legacy loader, save_part/save_part_type domain refusals, validate_project handling/sort_order hard issues. Docs: PLAN/CONTEXT/GUNRNG_CHANGES updated for the P2.3a preview contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: validate both handling scalars before either addition (re-grill NIT-1) A part with both an overflowing weight aggregate and an invalid ads_time_add now picks the same refusal code as the runtime's ResolvedGunHandling.resolveCanonical. Also corrects the prior commit's loose wording: libraryValidation gained only sortOrder/handling-scalar issues; duplicate/slot checks are main's shipped alias-aware bareId path (preserved), and the canonical-id collision check lives in partHandling.ts (re-grill NIT-2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion of the dev-integrated P2.3a handling preview (bit-level runtime parity). Feature PR #22 evidence: 709/4-skip sidecar, 588/588 renderer, re-grill SHIP.