Migrate SPI controller operations to async - #3161
Conversation
8c5ba0f to
ff823a4
Compare
f84c4ae to
36a90c4
Compare
36a90c4 to
0dc5c19
Compare
6e9364e to
5ab5adf
Compare
5ab5adf to
e9039a2
Compare
e9039a2 to
c4fddc6
Compare
c4fddc6 to
81ce542
Compare
81ce542 to
63cc407
Compare
|
@CodeRabbit review |
|
|
Warning Review limit reached
Next review available in: 58 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
63cc407 to
b813676
Compare
b813676 to
a3cd396
Compare
a3cd396 to
59a5ab5
Compare
59a5ab5 to
43aa673
Compare
43aa673 to
89201c8
Compare
89201c8 to
cfb906b
Compare
f1479ae to
f31d001
Compare
f31d001 to
8c5c5dc
Compare
Stacked on #3160.
Requires toitware/esp-idf#126, which adds a narrow public nonblocking SPI bus-acquire operation on top of the existing bus lock. That ESP-IDF PR is stacked on toitware/esp-idf#125.
This migrates ESP32 SPI controller transfers and explicit bus reservation away from blocking primitives.
Highlights:
A recent upstream ESP-IDF checkout was checked as well. It still has no public finite-time or nonblocking SPI bus acquisition, so #126 remains necessary and intentionally follows the existing ESP-IDF lock API.
This is a complete-transaction API. Half-buffer streaming and watermark callbacks are deliberately not included.