Skip to content

feat: Allow defining non-error exceptions for control flow#282

Closed
ditsuke wants to merge 1 commit into
tobymao:mainfrom
ditsuke:feat/silent-errors-for-control-flow
Closed

feat: Allow defining non-error exceptions for control flow#282
ditsuke wants to merge 1 commit into
tobymao:mainfrom
ditsuke:feat/silent-errors-for-control-flow

Conversation

@ditsuke

@ditsuke ditsuke commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Summary

In saq, retry policies and exceptions can be used as a form of control flow. For example, internally, we use a RetryException to indicate that a task should be retried at a later point. However, right now saq will still log the exception as an error which makes for some log noise. Here I propose to introduce a way to pass a set of exception types
that saq will not log as errors.

@tobymao

tobymao commented Dec 1, 2025

Copy link
Copy Markdown
Owner

Since this is only being used for error messaging, I don't see too much value in this. I'm not sure I'll want to bring this patch in.

@ditsuke

ditsuke commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Since this is only being used for error messaging, I don't see too much value in this. I'm not sure I'll want to bring this patch in.

Fair. Would you be more open to a more explicit control flow mechanism instead? Say something like a SaqDoRetry return/exception?

@tobymao

tobymao commented Dec 5, 2025

Copy link
Copy Markdown
Owner

yes

@tobymao

tobymao commented Dec 11, 2025

Copy link
Copy Markdown
Owner

closing for now due to inactivity

@tobymao tobymao closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants