feat: Allow defining non-error exceptions for control flow#282
Closed
ditsuke wants to merge 1 commit into
Closed
Conversation
Owner
|
Since this is only being used for error messaging, I don't see too much value in this. I'm not sure I'll want to bring this patch in. |
Contributor
Author
Fair. Would you be more open to a more explicit control flow mechanism instead? Say something like a |
Owner
|
yes |
Owner
|
closing for now due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In saq, retry policies and exceptions can be used as a form of control flow. For example, internally, we use a
RetryExceptionto indicate that a task should be retried at a later point. However, right now saq will still log the exception as an error which makes for some log noise. Here I propose to introduce a way to pass a set of exception typesthat saq will not log as errors.