fix: Do not process job; instead re enqueue if shutdown was requested#281
Closed
vikigenius wants to merge 1 commit into
Closed
fix: Do not process job; instead re enqueue if shutdown was requested#281vikigenius wants to merge 1 commit into
vikigenius wants to merge 1 commit into
Conversation
Owner
|
it's unclear exactly what problem this is solving. can you write a test? |
Contributor
Author
|
The idea is that if you were waiting a while for dequeue, a signal could have arrived in the meantime, but if you go ahead and start the job without checking you just started a job even though shutdown was requested. I will take a look at the tests and write one to showcase the behavior. |
Owner
|
i don't think you should re-enque it, it should probably just fail and let the retry handle it |
Contributor
Author
|
You are right, I don't think it's good to enqueue again and just introduces potential complexity. If we are letting it fail, we don't need to do anything, it will auto fail after timeout anyway I will close the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280