Fix --interactive irb mode not printing eval results#108
Merged
Conversation
IRB 1.x's output_value passes a buffer to inspect_last_value and reads from it (stream-output pattern) when paging is enabled and the inspector supports streaming, which is the default TTY case. The override returned @last_value but never wrote to the buffer, so nothing was printed. Append @last_value to the buffer instead.
Contributor
Author
|
@SamSaffron, would love a review from you on this please. |
SamSaffron
reviewed
May 21, 2026
| def inspect_last_value(output = +"") | ||
| @last_value | ||
| output << @last_value.to_s | ||
| end |
Collaborator
There was a problem hiding this comment.
wow this is confusing code ... why is it even taking in output ... why is it mutating it? I think we need some sort of test here that explains this ... what was the original intent here?
Contributor
Author
There was a problem hiding this comment.
ok @SamSaffron I've added an end-to-end test here. it should catch future regressions if/when IRB shuffles its internals again.
Collaborator
|
thanks, cut a new gem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IRB 1.x's
output_valuepasses a buffer toinspect_last_valueand reads from it when paging is enabled and the inspector supports streaming, which is the defaultTTYcase. The override returned@last_valuebut never wrote to the buffer, so nothing was printed. We need to append@last_valueto the buffer instead to get the inspected value printed.