Reflection Method Parameter Analysis partial support2#3
Reflection Method Parameter Analysis partial support2#3LakshanF wants to merge 2 commits intotlakollo:DAMUnsupportedReflectionAccessfrom
Conversation
|
|
||
| var source = DynamicallyAccessedMembersAnalyzer.TryGetSymbolFromOperation (invocationOperation.Instance, context); | ||
| if (source != null) | ||
| DynamicallyAccessedMembersAnalyzer.VerifyAnnotations (source.Value, memberTypes, context, invocationOperation.Syntax.GetLocation ()); |
There was a problem hiding this comment.
My BindingLogic in VerifyAnnotations is limited, for intrinsics it shouldn't be operating with the DynamicallyAccessedMembersTypes that we got from BindingFlags, it should operate directly with the binding flags since that's what the binder in Linker does. But either way, I don't think the linker will print nor keep anything with BindingFlags.CreateInstance, since is an ignored flag.
Also, I talked with Sven about this branch he suggested two things that I think are valuable, one is to divide the tasks into something more like the trimmer. Instead of filtering members and getting diagnostics in a single method, have two methods one that returns an enumeration of members (it will behave like the marking in trimmer) and another that only generates diagnostics.
The second recommendation was to divide this PR, Binding Logic + Intrinsics is an extensive change especially considering the new dataflow changes which make both tasks more complex.
There was a problem hiding this comment.
I'm a little behind our goal :-( Pushing a fix to handle intrinsic method separately. Still partial - BindingFlags are not fully handled and need to take care of RUC, DynamicDependency, delegates and type extension annotations (need to investigate if this can be handled in the mainline).
Will have a plan to discuss at our sync up today.
| bindingFlags = GetBindingFlagsFromValue (invocationOperation.Arguments[1]); | ||
| else | ||
| // Assume a default value for BindingFlags for methods that don't use BindingFlags as a parameter | ||
| bindingFlags = BindingFlags.Public; |
There was a problem hiding this comment.
Since the binder for intrinsics operates with BindingFlags the default BindingFlags for GetMethod are BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public
2 participants
This is partial since we need to handle normal invokes separately from reflection ones. The 2nd failing test case tracks the issue