test: rename misleading _deduplicates_ test to _does_not_dedup_#118
Open
strix-tkellogg wants to merge 1 commit into
Open
test: rename misleading _deduplicates_ test to _does_not_dedup_#118strix-tkellogg wants to merge 1 commit into
strix-tkellogg wants to merge 1 commit into
Conversation
The test asserts that _load_events returns both copies when a line appears in two rotated siblings (no dedup at this layer). Old name read like the opposite contract. Follow-up to #117. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #117 (Tyto's rotated-events fix).
The test added there asserts that
_load_eventsreturns both copies when the same line appears in two rotated siblings — i.e. no dedup at this layer. The old nametest_load_events_deduplicates_across_siblingsread like the opposite contract; future readers (and future me) would expect the test to assert dedup happens.Rename to
test_load_events_does_not_dedup_across_siblingsand tighten the docstring to match.No behavior change.
🤖 Generated with Claude Code