perf(git-locked): replace sed by cut#1256
Closed
Rudxain wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks, since this is labeled as an optimization as there any numbers to show it? |
Contributor
Author
no 😅, but here's my reasoning for why it should be faster:
|
Collaborator
|
Those could make sense, but I"m not sure if any of those statements are really true without benchmarking and reading the tools' code. Unless there's shown to be a big difference, I think it's best to leave it the way it is. Code churn has a cost |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a micro-optimization. I did it on my own, but I asked Copilot if it could be improved, it suggested these (not tested):