Fix bugs: memory leak, missing relocations, dead code, wrong section address#26
Closed
tishion wants to merge 2 commits into
Closed
Fix bugs: memory leak, missing relocations, dead code, wrong section address#26tishion wants to merge 2 commits into
tishion wants to merge 2 commits into
Conversation
…address - Fix memory leak in InitApiTable() - free pApis on failure - Add IMAGE_REL_BASED_HIGH and IMAGE_REL_BASED_LOW handling in RelocateModuleBase() - Remove dead code (unreachable else branch) in IsValidPEFormat() - Fix SetMemProtectStatus to use lpBase + VirtualAddress instead of overwritten PhysicalAddress - Remove unused ulBaseHigh variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed 4 bugs in the mmLoader codebase:
Bug 1: Memory Leak in InitApiTable()
src/mmLoader/mmLoader.c, line ~491pApistablepfnGlobalFree(pApis)before returning NULL on failure pathBug 2: Missing Relocation Types in RelocateModuleBase()
src/mmLoader/mmLoader.c, lines ~710-735Bug 3: Dead Code in IsValidPEFormat()
src/mmLoader/mmLoader.c, lines ~529-530else br = FALSE;is outside both #ifdef branches - unreachable dead code that doesn't properly handle non-standard machine typesBug 4: Wrong Section Base Address in SetMemProtectStatus()
src/mmLoader/mmLoader.c, line ~864 (previously ~851)pImageSectionHeader[idxSection].Misc.PhysicalAddresswhich was overwritten at line ~661 with the destination address, not the original file offset. This caused incorrect memory protection settings.pMemModule->lpBase + pImageSectionHeader[idxSection].VirtualAddressulBaseHighvariable@tishion can click here to continue refining the PR