Adding TRR for Disable or Modify M365 Logging#30
Merged
Conversation
vanvleeta
requested review from
a team,
dumpst3rfir3,
ineffectivecoder and
mjwhitta
June 29, 2026 15:43
mjwhitta
requested changes
Jun 30, 2026
mjwhitta
left a comment
Contributor
There was a problem hiding this comment.
Just a few things really, but I I believe @ineffectivecoder's suggestions from #29 apply as well.
Co-authored-by: Miles Whittaker <mjwhitta@users.noreply.github.com>
Co-authored-by: Miles Whittaker <mjwhitta@users.noreply.github.com>
mjwhitta
previously approved these changes
Jul 7, 2026
ineffectivecoder
requested changes
Jul 10, 2026
ineffectivecoder
left a comment
Contributor
There was a problem hiding this comment.
Looks like the images from trr0019 need to have updated file names for m365 from exo and a couple other things.
dumpst3rfir3
previously approved these changes
Jul 10, 2026
dumpst3rfir3
left a comment
Contributor
There was a problem hiding this comment.
I had some very minor suggestions, but otherwise LGTM
Co-authored-by: Chris Hodson <r2d2@sostup.id> Co-authored-by: Alex Garcia <149016698+dumpst3rfir3@users.noreply.github.com>
Co-authored-by: Chris Hodson <r2d2@sostup.id>
mjwhitta
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR also includes changes to rename the Exchange Online (exo) platform to a more general Microsoft365 (m365) platform. This required modifications to align TRR0019 with the updated platforms.