test: drop the stale meetAutoOrchestratorHandoff snapshot assertion

[senamakel]

What

Removes the meetAutoOrchestratorHandoff assertion from
json_rpc_app_state_snapshot_returns_runtime_shape in tests/json_rpc_e2e.rs. 11 deletions, tests only.

Why

main is red on Rust Core Coverage (cargo-llvm-cov):

thread 'json_rpc_app_state_snapshot_returns_runtime_shape' panicked at tests/json_rpc_e2e.rs:5500:5:
assertion `left == right` failed: expected meetAutoOrchestratorHandoff=false default
  left: None
 right: Some(false)

#5674 removed the meetings domain, so the app-state snapshot no longer carries the field, but this assertion still required it. The gate it guarded (#1299 — don't auto-hand a Meet transcript to the orchestrator without consent) no longer has anything to guard: there is no Meet call to end.

This is the third instance of the same drift. #5681 fixed the first two (the config_*_meet_settings RPC expectations in config_auth_app_state_connectivity_e2e.rs and domain_modules_e2e.rs); this one was missed there because it asserts the snapshot field name, not the RPC method name, so a meet_settings grep did not reach it.

Like the other two, this fails on every PR that merges main — it is currently the sole Rust Core Coverage failure on #5664, #5667, #5668, #5669 and #5671.

Not included

tests/raw_coverage/*.rs still contain [meet] auto_orchestrator_handoff = … blocks in their TOML config fixtures. Those are inert — an unknown config section is ignored, and those tests pass — so they are left alone rather than widening this fix.

Verification

$ git grep -c meetAutoOrchestratorHandoff tests/
0
$ cargo fmt --check      # clean
$ cargo check --features "$(bash scripts/ci/product-features.sh)" --test json_rpc_e2e
Finished `dev` profile in 1m 18s

Summary by CodeRabbit

• Tests
  • Updated end-to-end coverage to reflect the current runtime state snapshot without asserting a specific default value.

[tinysweeper]

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 81 embedded · openrouter/openai/text-embedding-3-small

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8215bb7f-63a3-410e-8275-a02262561b82

📥 Commits

Reviewing files that changed from the base of the PR and between 3118583 and 218f660.

📒 Files selected for processing (1)

• tests/json_rpc_e2e.rs

💤 Files with no reviewable changes (1)

• tests/json_rpc_e2e.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The JSON-RPC end-to-end snapshot test no longer asserts that meetAutoOrchestratorHandoff exists with value false. Runtime behavior and public API declarations remain unchanged.

Changes

Snapshot test update

Layer / File(s)	Summary
Remove obsolete snapshot assertion tests/json_rpc_e2e.rs	The app-state snapshot test no longer requires meetAutoOrchestratorHandoff to be present and false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 218f6

This change removes an outdated test expectation without changing production behavior; no actionable merge-blocking risk remains after normal checks and review.

Poem

I’m a rabbit, quick and bright,
I trimmed one check from test-night.
The snapshot now runs clean,
With no stale field to be seen.
Hop, hop—such a tidy sight!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the removal of the stale snapshot assertion described in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}