Dev by tinix84 · Pull Request #3 · tinix84/pyplecs

tinix84 · 2025-08-21T21:09:36Z

No description provided.

- Added orchestration module for managing simulation tasks, including queuing and worker management. - Introduced SimulationOrchestrator class to handle task submissions and completions. - Implemented SimulationTask and SimulationWorker classes for task representation and execution. - Enhanced caching mechanisms for simulation results. - Updated requirements.txt with necessary dependencies for orchestration and simulation. - Created setup_env.sh script for easy environment setup and package installation. - Added comprehensive tests for the new orchestration features, including configuration loading, simulation requests, and task management.

…ctured logging - Added centralized YAML configuration system - Implemented simulation orchestration with priority queues - Added intelligent hash-based caching with multiple storage formats - Created REST API with FastAPI for simulation management - Added structured logging with JSON output - Maintained full backward compatibility with legacy code - Added comprehensive test suite for new architecture - Updated requirements.txt with all necessary dependencies - Created setup script for environment management Ready for integration of: - Web GUI for monitoring - Parameter optimization engines - Model Context Protocol (MCP) server

- Implemented settings page for managing PLECS configuration, cache settings, orchestration settings, and web GUI settings. - Added functionality for saving and resetting settings with user feedback. - Created simulations page for managing and monitoring PLECS simulations, including filtering, pagination, and detailed views. - Developed modals for creating new simulations and viewing simulation details. - Integrated API calls for loading simulations and handling simulation actions (start, cancel, download results). - Added a test script for validating the web GUI endpoints and functionality.

…EADME

…ve options and logging

- Created a new smoke test suite in tests/test_smoke.py to validate core module imports and basic functionality. - Added default configuration file tools/config/default.yml with PLECS executable paths. - Implemented logging for the Windows installer in tools/installer_windows.log and status tracking in tools/installer_windows_status.json. - Updated the Windows installer scripts to include better error handling and logging. - Removed outdated macOS installer script tools/installers/macos_installer.sh and Windows installer script tools/installers/windows_installer.bat. - Enhanced the PowerShell installer to run smoke tests after installation and log results.

…import system

- Implemented a lightweight PLECS file parser in `plecs_parser.py` to extract component blocks and initialization commands. - Added functions to parse parameters and create an overview of PLECS files. - Enhanced `PlecsApp` to improve executable path resolution with fallback options. - Developed an end-to-end CLI test suite in `test_end_to_end_cli.py` to validate the complete simulation workflow. - Created unit tests for the parser in `test_parser.py` and simulation management in `test_simulation.py`. - Added debugging tools for parsing initialization commands and running sample PLECS files.

test: update test paths for PLECS file parser tests

…d work

- Implemented test suite for cache behavior with file changes and simulation type isolation in `test_cache_behavior.py`. - Created simple integration tests for real PLECS functionality in `test_plecs_integration_simple.py`. - Developed extensive integration tests for XML-RPC functionality in `test_plecs_xmlrpc_integration.py`. - Added comprehensive tests for real PLECS integration, parameter sweeps, and cache verification in `test_real_plecs_integration.py`. - Ensured tests cover scenarios for simulation execution, parameter modifications, and file change detection. - Verified cache behavior for identical and different parameters, ensuring correct isolation by simulation type.

…ution

…nce SimulationCache functionality tests: add comprehensive tests for cache behavior and real PLECS integration

… PlecsServer

…s and error handling

… parser functionality

Copilot

Pull Request Overview

This PR adds comprehensive test infrastructure and web interface templates for the PyPLECS simulation framework. The changes establish a complete testing strategy with automated, interactive, and GUI automation tests, while providing a modern web interface for managing simulations.

Key changes:

Comprehensive test suite reorganization with specialized test files for different testing scenarios
Complete web GUI templates for dashboard, simulations, cache management, and settings
Development tools and scripts for parser testing and debugging
Windows installer with PowerShell automation for streamlined setup

Reviewed Changes

Copilot reviewed 66 out of 79 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`tools/run_parse_sample.py`	Debug script for testing PLECS parser functionality
`tools/debug_parse_init.py`	Advanced debugging tool for PLECS initialization command parsing
`tools/installers/windows_installer.ps1`	Comprehensive PowerShell installer with Python download, verification, and PLECS detection
`tools/installers/USAGE_WINDOWS.md`	Documentation for Windows installer usage and CI integration
`tests/` (multiple files)	Complete test suite with automated, interactive, and GUI automation test categories
`templates/` (multiple files)	Modern responsive web interface templates for simulation management

Comments suppressed due to low confidence (1)

tests/test_real_plecs_integration.py:12

Import statement appears before sys.path manipulation which could cause import failures. The sys.path.append should be moved before the pyplecs imports.

import pytest

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-21T21:12:21Z

@@ -0,0 +1,7 @@
+import sys
+sys.path.insert(0, 'D:/git/pyplecs')


Hardcoded absolute path should be replaced with a relative path or environment variable to make the script portable across different development environments.

Suggested change

sys.path.insert(0, 'D:/git/pyplecs')

import os

# Use environment variable or relative path for pyplecs

pyplecs_path = os.environ.get('PYPLECS_PATH')

if not pyplecs_path:

# Default to ../pyplecs relative to this script

script_dir = os.path.dirname(os.path.abspath(__file__))

pyplecs_path = os.path.abspath(os.path.join(script_dir, '..', 'pyplecs'))

sys.path.insert(0, pyplecs_path)

Copilot · 2025-08-21T21:12:22Z

@@ -0,0 +1,26 @@
+import sys
+sys.path.insert(0, 'D:/git/pyplecs')


Hardcoded absolute path should be replaced with a relative path or environment variable to make the script portable across different development environments.

Suggested change

sys.path.insert(0, 'D:/git/pyplecs')

import os

sys.path.insert(0, os.environ.get('PYPLECS_PATH', os.path.abspath(os.path.join(os.path.dirname(__file__), '..', 'pyplecs'))))

Copilot · 2025-08-21T21:12:22Z

+
+    if ($Checksum) {
+        $actual = Get-FileSHA256 -Path $installer
+    if ($actual -ne $Checksum.ToLower()) { Log "Checksum mismatch: expected $Checksum got $actual"; $global:ExitCode = 3; $global:StatusMessage = 'checksum_mismatch'; Write-StatusJson $global:ExitCode $global:StatusMessage; exit $global:ExitCode }


[nitpick] Long conditional statement should be broken into multiple lines for better readability and maintainability.

Suggested change

if ($actual -ne $Checksum.ToLower()) { Log "Checksum mismatch: expected $Checksum got $actual"; $global:ExitCode = 3; $global:StatusMessage = 'checksum_mismatch'; Write-StatusJson $global:ExitCode $global:StatusMessage; exit $global:ExitCode }

if ($actual -ne $Checksum.ToLower()) {

Log "Checksum mismatch: expected $Checksum got $actual"

$global:ExitCode = 3

$global:StatusMessage = 'checksum_mismatch'

Write-StatusJson $global:ExitCode $global:StatusMessage

exit $global:ExitCode

}

Copilot · 2025-08-21T21:12:22Z

+    if (-not $SkipAuthSignatureCheck) {
+        $sigOk = Verify-AuthenticodeSignature -Path $installer
+    if ($sigOk) { Log "Authenticode signature valid" } else { Log "Authenticode signature invalid or not present"; if (-not $SkipAuthSignatureCheck) { $global:ExitCode = 4; $global:StatusMessage = 'auth_signature_invalid'; Write-StatusJson $global:ExitCode $global:StatusMessage; exit $global:ExitCode } }
+    }


[nitpick] Complex conditional logic with nested if statements should be refactored into separate functions or broken into multiple lines for better readability.

Suggested change

}

if ($sigOk) {

Log "Authenticode signature valid"

} else {

Log "Authenticode signature invalid or not present"

if (-not $SkipAuthSignatureCheck) {

$global:ExitCode = 4

$global:StatusMessage = 'auth_signature_invalid'

Write-StatusJson $global:ExitCode $global:StatusMessage

exit $global:ExitCode

}

}

}

Copilot · 2025-08-21T21:12:23Z

+
+
+def _sample_model_path():
+    # Usa sempre il path assoluto del modello di test


Comment is in Italian instead of English. Should be translated to maintain consistency with the rest of the codebase.

Suggested change

# Usa sempre il path assoluto del modello di test

# Always use the absolute path of the test model

Copilot · 2025-08-21T21:12:23Z

+# Add parent directory to path for imports
+sys.path.insert(0, os.path.dirname(os.path.dirname(__file__)))
+
+from pyplecs.plecs_parser import parse_plecs_file


Import statement appears before sys.path manipulation which could cause import failures. The sys.path.insert should be moved before the pyplecs imports.

Copilot · 2025-08-21T21:12:23Z

+import shutil
+from pathlib import Path
+from pyplecs.cache import SimulationCache
+from cli_demo_nomocks import RealPlecsSimulator


Import from 'cli_demo_nomocks' suggests this is importing from a demo/example file rather than the main codebase, which could cause issues if the demo file is moved or renamed.

Suggested change

from cli_demo_nomocks import RealPlecsSimulator

from pyplecs.simulator import RealPlecsSimulator

Copilot · 2025-08-21T21:12:24Z

+{% endblock %}
+
+{% block extra_js %}
+<script>


[nitpick] Large JavaScript block in HTML template should be moved to a separate .js file for better maintainability and caching.

Copilot · 2025-08-21T21:12:24Z

+{% endblock %}
+
+{% block extra_js %}
+<script>


[nitpick] Large JavaScript block in HTML template should be moved to a separate .js file for better maintainability and caching.

tinix84 added 20 commits August 19, 2025 08:56

ci: add package coherence GitHub Actions workflow

a8afc8b

chore: remove unused CI configuration files and clean up .gitignore

3931f3d

installer(windows): interactive double-clickable installer, update docs

05a48ed

restore: bring back full config/default.yml from 28f568d

9b60d8a

installer(windows): add exit codes, logging, JSON status; add usage R…

f15d6c4

…EADME

feat(installer): add advanced PowerShell installer with non-interacti…

3487f15

…ve options and logging

refactor: clean up codebase by removing unused files and simplifying …

3a011e1

…import system

feat(cli): add end-to-end CLI workflow demo for PLECS file processing

3c9c5e8

test: update test paths for PLECS file parser tests

docs: add workflow freeze memo documenting project state and complete…

03f1530

…d work

docs: add detailed analysis of failed tests and action plan for resol…

7f1523a

…ution

feat(cache): implement caching support in RealPlecsSimulator and enha…

f6b03d8

…nce SimulationCache functionality tests: add comprehensive tests for cache behavior and real PLECS integration

feat(plecs): add batch simulation support and enhance RPC wrappers in…

62ab6a7

… PlecsServer

feat(tests): enhance GUI and interactive tests with environment check…

9818b12

…s and error handling

feat(tests): add new unit tests for installer, model vars parser, and…

c56eaf0

… parser functionality

Copilot AI review requested due to automatic review settings August 21, 2025 21:09

tinix84 merged commit 57b0ffb into master Aug 21, 2025
1 check failed

Copilot AI reviewed Aug 21, 2025

View reviewed changes

Navigation Menu

Dev - #3

Dev#3
tinix84 merged 20 commits into
masterfrom
dev

tinix84 commented Aug 21, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,7 @@
		import sys
		sys.path.insert(0, 'D:/git/pyplecs')

-sys.path.insert(0, 'D:/git/pyplecs')
+import os
+# Use environment variable or relative path for pyplecs
+pyplecs_path = os.environ.get('PYPLECS_PATH')
+if not pyplecs_path:
+    # Default to ../pyplecs relative to this script
+    script_dir = os.path.dirname(os.path.abspath(__file__))
+    pyplecs_path = os.path.abspath(os.path.join(script_dir, '..', 'pyplecs'))
+sys.path.insert(0, pyplecs_path)

		@@ -0,0 +1,26 @@
		import sys
		sys.path.insert(0, 'D:/git/pyplecs')

	sys.path.insert(0, 'D:/git/pyplecs')
	import os
	sys.path.insert(0, os.environ.get('PYPLECS_PATH', os.path.abspath(os.path.join(os.path.dirname(__file__), '..', 'pyplecs'))))



		def _sample_model_path():
		# Usa sempre il path assoluto del modello di test

	# Usa sempre il path assoluto del modello di test
	# Always use the absolute path of the test model

	from cli_demo_nomocks import RealPlecsSimulator
	from pyplecs.simulator import RealPlecsSimulator

Conversation

tinix84 commented Aug 21, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants