Support symfony/console version 8#29
Merged
Merged
Conversation
timoschinkel
force-pushed
the
symfony-console-8
branch
from
eb8ca96 to
d360a42
Compare
Psalm was tied to `~6.4.0` due to vimeo/psalm#11270 - I was running an "unwanted" version locally, and was too lazy to update. However, in order to support `symfony/console` version 8 we need a newer version of Psalm. I did suppress the `MissingOverrideAttribute`, because I don't agree that implementing a method that is defined in an interface would require an `#[Override]` attribute. See vimeo/psalm#11305
It was already deprecated, but in `symfony/console` version 8 it has been removed completely.
timoschinkel
force-pushed
the
symfony-console-8
branch
from
e4f253b to
e224347
Compare
`symfony/console:8.x` requires PHP 8.4. This blocks the matix as it was created. This rearranges the matrix to only PHP versions and separate steps for Symfony versions. Less parallelism, but now it is possible to only test against Symfony 8 on PHP 8.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #28