Chore/flutter 3.47 - #56
Merged
Merged
Conversation
flutter_localizations pins intl to an exact version per Flutter release (0.20.2 on 3.44.x), so any concrete constraint here is redundant at best and unsolvable at worst: dependabot's intl ^0.20.3 bump (PR branch dependabot/pub/minor-and-patch-293bb9c172) can never resolve and re-fails CI after every merge rebases it. `any` is the documented form for SDK-pinned packages (https://dart.dev/go/sdk-version-pinning) and leaves nothing for dependabot to bump. Resolution is unchanged (lockfile identical: intl 0.20.2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Flutter 3.47 supports AGP built-in Kotlin first-class: the kotlin-android force-apply is now gated on isBuiltInKotlinEnabled() (AGP >= 9 with android.builtInKotlin=true skips it entirely; flutter/flutter#184837 closed), so the benign "KGP was not found on the classpath" warning from 3.44.x is gone. flutter_localizations now constrains intl with a caret (^0.20.3 instead of the exact 0.20.2 pin), so intl resolves to 0.20.3 under the app's `any` constraint. - CI: flutter-version 3.44.4 -> 3.47.0 in test/e2e/codeql/release workflows - settings.gradle.kts: declared (apply false) KGP 2.2.21 -> 2.4.0, the 3.47 template version — clears 3.47's "Kotlin version will soon be dropped, upgrade to at least 2.3.20" build warning; KGP is still never applied (built-in Kotlin compiles) - analysis_options.yaml: analyzer excludes for build/ and platform dirs, auto-migrated by the 3.47 tool on pub get - pubspec.lock: intl 0.20.3, matcher 0.12.20, meta 1.19.0, test_api 0.7.12, vector_math 2.4.2 (all SDK-pinned) - CLAUDE.md / gradle.properties comments updated; android.newDsl=false still required and still works on 3.47 Verified on 3.47.0: analyze clean (+ --suggestions compatible java/gradle/agp/kgp), 124 Dart tests, Kotlin :app:test, debug (x64) and release (arm64, R8, 19.0MB) APKs build with no KGP warnings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.