added ares optimizer and helper funcs#1
Open
woodykang wants to merge 2 commits into
Open
Conversation
shubhagrawal30
self-requested a review
April 27, 2026 21:06
| phi = np.angle(S21) # phase of S21 | ||
|
|
||
| # normalize to same baseline amplitude | ||
| S21 /= np.mean(mag_lin[:20]) |
Collaborator
There was a problem hiding this comment.
put 20 as a input to function
|
|
||
| # remove linear phase | ||
| phi = np.angle(S21) | ||
| phi_1 = phi[10] |
Collaborator
There was a problem hiding this comment.
put 10 as input to func
| phi = np.angle(S21) # phase of S21 | ||
|
|
||
| # normalize to same baseline amplitude | ||
| S21 /= np.mean(mag_lin[:20]) |
Collaborator
There was a problem hiding this comment.
have 20 as a function argument
| # remove linear phase | ||
| phi = np.angle(S21) | ||
| phi_1 = phi[10] | ||
| phi_2 = phi[-10] |
| df = f[1]-f[0] | ||
| dI = np.diff(I)/df | ||
| dQ = np.diff(Q)/df | ||
| dIQ = np.sqrt(dI**2 + dQ**2) |
Collaborator
There was a problem hiding this comment.
Do you end up using any information about a quality factor in here? You should be able to get a quick estimate of the line width without curve fitting?
Author
There was a problem hiding this comment.
I do not use any information about the quality factor. Do we need to have a quick estiamte?
Collaborator
There was a problem hiding this comment.
I remember talking about this once, where you scale the threshold by a quality factor to make it robust? I guess if it works, it works
shubhagrawal30
self-requested a review
July 9, 2026 21:36
shubhagrawal30
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optimize_ares_siq and its helper functions.
It biases KIDs to a_nl ~ 0.7 by examining the spacing in the IQ circle and determining if a KID is bifurcated or not.