XSC trimming#152
Draft
ianlowe13 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a lot of vestigial code for the old star cameras, which unfortunately has been hard to remove due to the way that it is wound through the entire program. I am taking time to do static analysis and remove this code from the main MCP base and, where appropriate, dump it into legacy mcp reference material. This first round compiles, meaning I haven't obviously broken anything, but we may have weird behavior when we actually run the flight software.
changes so far:
remove XSC sensor and pointing files
remove calls to XSC functions that serve no purpose anymore
remove XSC commands and command data init
todos:
rename kept ISC, OSC, XSCn -> SC1 and SC2
remove old tlm channels
remove unnecessary structs and confusing calls to variables
test test test
???