test: clean up keyspace kernel mode tests#10987
Conversation
Signed-off-by: disksing <i@disksing.com>
ce7a226 to
fb71004
Compare
📝 WalkthroughWalkthroughTest files in ChangesKeyspace Test Refactor
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: disksing <i@disksing.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10987 +/- ##
==========================================
- Coverage 79.21% 79.18% -0.03%
==========================================
Files 541 541
Lines 75677 75847 +170
==========================================
+ Hits 59949 60063 +114
- Misses 11491 11544 +53
- Partials 4237 4240 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/test pull-build |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@disksing: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #10989
This PR splits out the keyspace test cleanup portion from the API V3 PD
client work, so later API and TSO routing changes can stay focused.
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note