integration_tests: remove temporary TiDB replaces#2021
Conversation
TiDB master now contains the PD client mock interface adaptations required by the integration module. Point TiDB and its parser module back to the official master pseudo-version and remove the temporary fork replaces. Signed-off-by: Yuhao Zhang <yhzhang00@outlook.com>
|
Hi @YuhaoZhang00. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesIntegration test dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What changed
github.com/YuhaoZhang00/tidbreplaces added by resourcecontrol, tikvrpc: add PredictedReadBytes hint for RC paging pre-charge #1947.github.com/pingcap/tidbandgithub.com/pingcap/tidb/pkg/parserto the official TiDB master pseudo-version at10292a4f8697.Why
#1947 temporarily used an adapted TiDB fork because TiDB master had not yet adopted the current PD client mock interfaces. The required TiDB adaptations have since merged in pingcap/tidb#67941, so the integration module no longer needs the fork overrides.
Validation
go mod verifyenv GOCACHE=/tmp/client-go-remove-tidb-replace-gocache go test ./... -run "^$" -count=0git diff --check upstream/master...HEADRelated: #1947, pingcap/tidb#67941
Summary by CodeRabbit