fix(makefile): lowercase path segments in COMPOSE_PROJECT_NAME - #1150
Open
vdbrown2 wants to merge 2 commits into
Open
fix(makefile): lowercase path segments in COMPOSE_PROJECT_NAME#1150vdbrown2 wants to merge 2 commits into
vdbrown2 wants to merge 2 commits into
Conversation
Docker Compose requires project names to be all lowercase. The auto-generated <parent>-<repo> name only sanitized special characters, so a capitalized parent directory (e.g. ~/Projects/thunderbolt) produced an invalid project name and made `make up` fail.
vdbrown2
temporarily deployed
to
fork-preview-approval
July 28, 2026 20:44 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Preview environment deployed 🚀
Stack: Auto-destroys on PR close/merge. Login via the bundled Keycloak realm — |
Author
|
Pushed a follow-up commit adding a code comment for the `sed` character class change, in case it stands out in review: it was narrowed from `[^a-zA-Z0-9._-]` to `[^a-z0-9._-]` since the new `tr` step already lowercases both segments before `sed` runs. Keeping `A-Z` in the allowed set would've been dead code, and dropping it makes `sed` assert "this is already lowercase" rather than just stripping stray characters — so a future reordering of the pipe that reintroduces uppercase would get caught instead of silently passing through. |
vdbrown2
temporarily deployed
to
fork-preview-approval
July 28, 2026 20:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make upfails withinvalid project name "...": must consist only of lowercase alphanumeric characters, hyphens, and underscores...whenever the repo's parent directory contains an uppercase letter (e.g.~/Projects/thunderbolt).COMPOSE_PROJECT_NAME(<parent>-<repo>) already sanitized special characters viased, but never lowercased the segments, so Docker Compose rejected the result.tr '[:upper:]' '[:lower:]'before sanitizing each path segment so the generated project name is always valid.Test plan
make uperrored with the exact message from the issue.fake-parent-dir-thunderbolt-test) is fully lowercase for a mixed-case path.make up/make downin the real repo (parent dir~/Projects) with noCOMPOSE_PROJECT_NAMEoverride — containers started successfully asprojects-thunderbolt-*.