fix(ci): resolve build failures from dead domain and keisan API break#38
Open
canji1983 wants to merge 1 commit into
Open
fix(ci): resolve build failures from dead domain and keisan API break#38canji1983 wants to merge 1 commit into
canji1983 wants to merge 1 commit into
Conversation
- Remove dead repository.ichiro-its.org setup steps (DNS unreachable) - Add keisan as a workspace source dependency, pinned to commit 593c9dc (last version before Quaternion was converted to a template) - Explicitly set ROS 2 distro to iron in both build and deploy workflows - Update actions/checkout from v2.3.4 to v4 - Update appleboy/scp-action from @master to @v0.1.7 - Update appleboy/ssh-action from @master to @v1.0.3 Fixes: keisan dependency unresolvable, Quaternion template mismatch, ROS 2 distro drift from Foxy to Iron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all identified CI build failures in the tosshin project. The repository has been dormant since 2021-06-28, and multiple external dependencies have broken since then.
Root Causes Fixed
repository.ichiro-its.orgDNS is dead (curl exit code 6)keisannot in standard rosdep databaseactions/checkoutQuaternionwas converted toQuaternion<T>template (2021-08-28), breaking tosshin's non-templated usage593c9dc(last pre-template version)ironbut no distro was specifieddistro: ironChanges
.github/workflows/build-and-test.ymlactions/checkout@v2.3.4→@v4curl | bashsteps forrepository.ichiro-its.orgactions/checkout@v4step to cloneichiro-its/keisanat pinned commit593c9dcdistro: ironinput toichiro-its/ros2-build-and-test-action.github/workflows/deploy-debian.ymlros2-distro: ironinput toros2-build-debian-actionappleboy/scp-action@master→@v0.1.7appleboy/ssh-action@master→@v1.0.3.github/workflows/deploy-documentation.ymlactions/checkout@v2.3.4→@v4How It Works
The
ichiro-its/ros2-build-and-test-actioninternally runs:The
--ignore-srcflag means packages already in the workspace (keisan + tosshin) are not looked up in rosdep — they're built from source bycolcon build. This eliminates the need for the dead custom Debian/rosdep repositories.Known Remaining Risks
repository.ichiro-its.orgis dead, the SSH server is likely also unreachable. The team should verifysecrets.SSH_HOSTor disable the deploy workflow.libargparse-dev— Listed inpackage.xmlbut not in standard rosdep. It IS available as an Ubuntu apt package, so rosdep should resolve it via apt fallback. If this fails, it can be added to a custom rosdep source.keisan::Quaternion<double>instead ofkeisan::Quaternion(see Phase 2 Option B in the analysis).Verification
Push this PR to trigger the
Build and Testworkflow. Expected result:593c9dc--ignore-src)colcon buildcompiles both keisan and tosshincolcon testpasses gtest and lint checks