SCAL-313693 Create an visual embed sdk flag for controlling the new e…#532
Open
podishetti-nagavenu wants to merge 1 commit into
Open
SCAL-313693 Create an visual embed sdk flag for controlling the new e…#532podishetti-nagavenu wants to merge 1 commit into
podishetti-nagavenu wants to merge 1 commit into
Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the enableConnectionNewExperience flag to AppEmbed, allowing users to enable the new connection experience. The changes include updates to the AppViewConfig interface, the Param enum, and the AppEmbed class to handle the parameter in the iframe URL. Unit tests were added to verify the URL generation for various flag states. A review comment was provided to verify that the @version JSDoc tag adheres to the canonical SDK-to-ThoughtSpot Cloud version mapping.
| * This flag is used to enable the new connection experience for AppEmbed. | ||
| * | ||
| * Supported embed types: `AppEmbed` | ||
| * @version SDK: 1.51.0 | ThoughtSpot Cloud: 26.8.0.cl |
Contributor
There was a problem hiding this comment.
The @version tag for SDK version 1.51.0 should map to ThoughtSpot Cloud version 26.8.0.cl according to the canonical mapping sequence established in the style guide.
podishetti-nagavenu
force-pushed
the
SCAL-313693
branch
from
d7ee6f0 to
a3d6aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xperience in TSE