Skip to content

SCAL-311824 enabled liveboard download format flags by default in embed#528

Open
fathima-nooha wants to merge 2 commits into
mainfrom
SCAL-311824
Open

SCAL-311824 enabled liveboard download format flags by default in embed#528
fathima-nooha wants to merge 2 commits into
mainfrom
SCAL-311824

Conversation

@fathima-nooha
Copy link
Copy Markdown
Collaborator

Enabling flags for PnC (Pick and Choose) and WYSIWYG(What you see is what you get) by default for embed.

Both these can only be enabled together due to their impact on embed actions.

@fathima-nooha fathima-nooha requested a review from a team as a code owner May 13, 2026 01:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default values for several boolean flags (isLiveboardXLSXCSVDownloadEnabled, isGranularXLSXCSVSchedulesEnabled, and isContinuousLiveboardPDFEnabled) from false to true within the AppEmbed and LiveboardEmbed classes. Review feedback highlights that isContinuousLiveboardPDFEnabled must remain explicitly defaulted to false to ensure the feature is disabled for TSE deployments. Furthermore, the reviewer pointed out a violation of the Repository Style Guide (Rule 12), recommending that boolean parameters like isLiveboardXLSXCSVDownloadEnabled and isGranularXLSXCSVSchedulesEnabled should not have default values in destructuring to avoid unnecessary URL bloat.

Comment thread src/embed/app.ts Outdated
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/app.ts Outdated
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/liveboard.ts
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/app.ts Outdated
@fathima-nooha fathima-nooha force-pushed the SCAL-311824 branch 2 times, most recently from 9318f72 to e75472f Compare May 18, 2026 12:09
@shivam-kumar-ts
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and default logic for the isContinuousLiveboardPDFEnabled, isLiveboardXLSXCSVDownloadEnabled, and isGranularXLSXCSVSchedulesEnabled flags in both AppEmbed and LiveboardEmbed, transitioning them to be enabled by default. The review feedback identifies several JSDoc violations, specifically regarding the canonical tag order where @Version must precede @default, and incorrect SDK-to-ThoughtSpot version mappings. Additionally, the reviewer noted that isContinuousLiveboardPDFEnabled should be explicitly defaulted to false to ensure the feature remains disabled for specific environments.

Comment thread src/embed/app.ts Outdated
Comment thread src/embed/app.ts
Comment thread src/embed/app.ts
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/liveboard.ts
Comment thread src/embed/liveboard.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants