SCAL-311824 enabled liveboard download format flags by default in embed#528
SCAL-311824 enabled liveboard download format flags by default in embed#528fathima-nooha wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the default values for several boolean flags (isLiveboardXLSXCSVDownloadEnabled, isGranularXLSXCSVSchedulesEnabled, and isContinuousLiveboardPDFEnabled) from false to true within the AppEmbed and LiveboardEmbed classes. Review feedback highlights that isContinuousLiveboardPDFEnabled must remain explicitly defaulted to false to ensure the feature is disabled for TSE deployments. Furthermore, the reviewer pointed out a violation of the Repository Style Guide (Rule 12), recommending that boolean parameters like isLiveboardXLSXCSVDownloadEnabled and isGranularXLSXCSVSchedulesEnabled should not have default values in destructuring to avoid unnecessary URL bloat.
6a2c66b to
6c68d46
Compare
b0bfc7d to
daf2f09
Compare
9318f72 to
e75472f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and default logic for the isContinuousLiveboardPDFEnabled, isLiveboardXLSXCSVDownloadEnabled, and isGranularXLSXCSVSchedulesEnabled flags in both AppEmbed and LiveboardEmbed, transitioning them to be enabled by default. The review feedback identifies several JSDoc violations, specifically regarding the canonical tag order where @Version must precede @default, and incorrect SDK-to-ThoughtSpot version mappings. Additionally, the reviewer noted that isContinuousLiveboardPDFEnabled should be explicitly defaulted to false to ensure the feature remains disabled for specific environments.
e75472f to
a8c8a22
Compare
a8c8a22 to
f8a2b93
Compare
Enabling flags for PnC (Pick and Choose) and WYSIWYG(What you see is what you get) by default for embed.
Both these can only be enabled together due to their impact on embed actions.