Run CI on every pull request, and keep agent tooling out of the statistics - #1
Merged
Merged
Conversation
…stics `main` is about to stop accepting direct pushes, so it needs something to gate on. The workflow runs what a contributor would run: lint, types, tests and build on Linux, and fmt, clippy and the host's tests on Windows, where the app ships. Writing it found two things it would have failed on immediately. `cargo fmt --check` had a diff left from the last scan change, and clippy caught a `root` parameter in `collect` that was only ever passed to itself — a leftover from before the walker stopped needing the base path. Both fixed rather than tolerated, or the badge would be red on its first run. .gitattributes marks the agent folders vendored so GitHub stops counting their configuration as this project's source, and marks the three generated files as generated so a diff of them collapses. Both also carry export-ignore, so a release archive holds the program and not the tools that helped write it. The README gains what a public repository needs: badges, the versions you have to have installed, and a contributing section that says what the tests actually care about — every derived theme at 4.5:1, app.css held to the same bar, and nothing reaching the network at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis about to stop accepting direct pushes, so it needs something to gate on.CI runs what a contributor would run: lint, types, tests and build on Linux, and
cargo fmt,clippyand the host's tests on Windows, where the app ships.Writing it found two things it would have failed on immediately, both fixed here rather than tolerated:
cargo fmt --checkhad a diff left over from the last scan change.rootparameter incollectthat was only ever passed to itself — a leftover from before the walker stopped needing the base path..gitattributesmarks the agent folders vendored, so GitHub stops counting their configuration as this project's source, and marks the three generated files as generated so their diffs collapse. Both also carryexport-ignore, so a release archive holds the program and not the tools that helped write it.README gains what a public repository needs: badges, the versions you have to have installed, and a contributing section saying what the tests actually care about.
Verified locally: lint, svelte-check over 995 files, 303 tests, the front-end build, and cargo fmt/clippy/test all clean.