Take out the controls that ask twice or answer nothing - #7
Merged
Conversation
Level, time, event id and provider each had two controls: one in the toolbar that narrowed the query sent to Windows, one under the column header that narrowed what was already loaded. Same names, different reach, and nothing on screen said which was which. The columns keep them — a tick list with counts beats typing exact provider names, and an expression beats a comma-separated list of ids. The toolbar keeps only what has to be decided before reading: which channel, and the button. What is loaded now says how far back it reaches, beside the count, because a column filter can only narrow what was read: without that, an empty result for last Tuesday looks like a quiet one. The menu loses Save, Print, Refresh, Choose columns, Clear all filters and Documentation, which existed to be looked at. An entry that answers a click with "not built yet" is worse than no entry. Exit, Settings and About stay, and do what they say.
thorstenalpers
pushed a commit
that referenced
this pull request
Aug 31, 2026
PR #7 removed the same duplicate toolbar controls in parallel. This branch goes further and its resolutions win: the menu bar is deleted rather than slimmed, and the toolbar keys leave the catalogues. What #7 added on top survives — the oldest/newest getters, the loaded-span readout beside the count, and its store tests — and the span string now exists in all eleven languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolbar asked what the columns already ask
Level, time, event id and provider each had two controls. They were not the same control twice — the toolbar narrowed the query sent to Windows, the column header narrows what was already loaded — but nothing on screen said so, which makes them read as duplicates because in practice they are.
The columns win: a tick list with counts beats typing exact provider names, and
>7000 !10016beats a comma-separated list. The toolbar keeps only what has to be decided before reading anything: which channel, and the button.What is loaded now states its span beside the count —
4 731 events · 22/08/2026 09:12 to 31/08/2026 17:40 · read in 41 ms. A column filter can only narrow what was read, so without that an empty result for last Tuesday looks exactly like a quiet Tuesday.The menu had entries that only apologised
Save events as…, Print…, Refresh, Choose columns…, Clear all filters and Documentation all answered a click with "not built yet". Gone. Exit, Settings and About stay, and do what they say.
🤖 Generated with Claude Code