Run the release only when somebody asks for one - #6
Merged
Conversation
I read "auto release" as "release when the version changes" and put a push trigger on main, so every merge started a release run. That is not what a release is: merging a pull request says nothing about whether one has been decided. The workflow now runs on workflow_dispatch alone. Pressing it builds, signs, creates the tag at that commit and publishes — the tag is still the pipeline's job, never anyone's by hand. A `dry_run` tick keeps the rehearsal. A version that already has a tag is refused in seconds rather than overwritten, because that tag is the one thing somebody may already have downloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My mistake in #5. I read "auto release" as "release when the version changes" and put
push: branches: [main]on the workflow — so every merge since has started a release run. Merging a pull request says nothing about whether a release has been decided.What it does now
workflow_dispatchonly. Press the button and it builds, signs, creates the tagv<version>at that commit and publishes the installer, its.sigandlatest.json. Nobody tags by hand — that was the other half of the ask.package.jsondry_runtickA tag that already names a release is the one thing somebody may already have downloaded, so it is refused rather than moved. Bump first:
🤖 Generated with Claude Code