Ship the installer this run built, not whatever the cache held - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The v1.0.0 release shipped with two installers inside — this run's 1.0.0 and the 0.1.0 the cargo cache had carried over in
target/release/bundle/. The*-setup.exeglob matched both,Select-Object -First 1picked the one that sorts first, andlatest.jsonended up claiming version 1.0.0 while pointing at the 0.1.0 installer. The in-app updater then dutifully downloaded, verified and installed the old version: update "works", app stays old.The fix
latest.jsonand the release upload name the installer outright —OpenEventViewer_<version>_x64-setup.exe— so a stray file is a hard failure (fail_on_unmatched_files), never a silently wrong manifest.🤖 Generated with Claude Code